Add plugin-hook-based scoped PostgreSQL introspection - #3
Draft
Zetazzz wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is an alternative implementation of #2 that keeps the existing introspection pipeline intact and introduces scoped introspection through a functional query builder and plugin hook.
makeIntrospectionQuery()makeSchemaScopedIntrospectionQuery()as a separate functional query builderpgIntrospection_querygather hook before query executionPgScopedIntrospectionPluginand dedicated preset that replace the query through that hookPgIntrospectionPlugindefaultPresetunchangedThe scoped query retains transitive dependencies needed for relations, constraints, function signatures, domains, arrays, ranges, multiranges, indexes, inheritance, and extension metadata. Configuration may be enabled per PostgreSQL service with a boolean or scoped options.
This PR is intended as an architectural alternative to #2, not as an additional change to merge alongside it.
Why this shape
The core plugin gains one generic extension point but no scoped-introspection policy. All query selection and scoped-result validation live in the separate optional plugin. This minimizes changes to the stock execution path and lets other query strategies use the same hook.
Validation
pg-introspection: build passed; 41/41 tests passedgraphile-build-pg: build passed; 25/25 tests passedpg_trgmGIN/GiST indexesgit diff --checkpassed